Skip to content

Upgrade ElectronNET to ElectronNET.Core 0.4.1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xnodeoncode merged 3 commits into from
Mar 7, 2026
Merged

Upgrade ElectronNET to ElectronNET.Core 0.4.1 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cfcfe5
Upgrade to ElectronNET.Core 0.4.1.
Mar 7, 2026
979a308
Fixed issue with application path.
Mar 7, 2026
fba3324
Add runtime identifier conditionals.
Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ sp_credentials.json

publish_profile.xml

# Electron publish output — releases managed via GitHub Releases
4-Nine/publish/


# Python virtual environment created per-project
.venv/
Expand Down
5 changes: 4 additions & 1 deletion 1-Nine.Infrastructure/Nine.Infrastructure.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,17 @@
<Version>0.2.0</Version>
</PropertyGroup>

<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\0-Nine.Core\Nine.Core.csproj" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.1" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="10.0.1" />
<PackageReference Include="ElectronNET.API" Version="23.6.2" />
<PackageReference Include="SendGrid" Version="9.29.3" />
<PackageReference Include="SQLitePCLRaw.bundle_e_sqlcipher" Version="2.1.11" />
<PackageReference Include="Twilio" Version="7.14.0" />
Expand Down
21 changes: 0 additions & 21 deletions 4-Nine/ElectronHostHook/package-lock.json
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions 4-Nine/ElectronHostHook/package.json
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions 4-Nine/ElectronHostHook/tsconfig.json
View file
Open in desktop

This file was deleted.

21 changes: 20 additions & 1 deletion 4-Nine/Nine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<!-- Set per-OS to override ElectronNET.Core.props default of win-x64 -->
<RuntimeIdentifier Condition="$([MSBuild]::IsOSPlatform('Linux'))">linux-x64</RuntimeIdentifier>
<RuntimeIdentifier Condition="$([MSBuild]::IsOSPlatform('Windows'))">win-x64</RuntimeIdentifier>
<RuntimeIdentifier Condition="$([MSBuild]::IsOSPlatform('OSX'))">osx-x64</RuntimeIdentifier>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<UserSecretsId>aspnet-Nine-c69b6efe-bb20-41de-8cba-044207ebdce1</UserSecretsId>
Expand All @@ -14,6 +18,20 @@
<InformationalVersion>1.0.0</InformationalVersion>
</PropertyGroup>

<PropertyGroup Label="ElectronNetCommon">
<ElectronVersion>30.4.0</ElectronVersion>
<ElectronBuilderVersion>26.0</ElectronBuilderVersion>
<ElectronSingleInstance>false</ElectronSingleInstance>
<ElectronSplashScreen>wwwroot/assets/splash.png</ElectronSplashScreen>
<ElectronIcon>Assets/icon.png</ElectronIcon>
<ElectronPackageId>co.nineapp.nine</ElectronPackageId>
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ElectronPackageId is set to co.nineapp.nine, but existing desktop metadata in the repo uses com.nineapp.nine (e.g., Assets/com.nineapp.nine.appdata.xml, and the added desktop-config.bk uses com.nineapp.nine). This inconsistency can break Linux metadata copying and app identity/update behavior; pick one identifier and make the configs/assets consistent.

Suggested change
<ElectronPackageId>co.nineapp.nine</ElectronPackageId>
<ElectronPackageId>com.nineapp.nine</ElectronPackageId>

Copilot uses AI. Check for mistakes.
<Title>Nine</Title>
</PropertyGroup>

<ItemGroup>
<AssemblyMetadata Include="AspNetHttpPort" Value="8888" />
</ItemGroup>

<ItemGroup>
<!-- Copy wwwroot assets to Assets folder for Electron -->
<None Update="wwwroot\assets\splash.png">
Expand Down Expand Up @@ -44,7 +62,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="ElectronNET.API" Version="23.6.2" />
<PackageReference Include="ElectronNET.Core" Version="0.4.1" />
<PackageReference Include="ElectronNET.Core.AspNet" Version="0.4.1" />
<PackageReference Include="Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore" Version="10.0.1" />
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="10.0.1" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="10.0.1">
Expand Down
Loading