diffusion: drop unused import, fix isort ordering (#3421)#3423
Open
brendancol wants to merge 1 commit into
Open
diffusion: drop unused import, fix isort ordering (#3421)#3423brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
Remove the unused not_implemented_func import (flake8 F401) and re-sort the import block to the configured isort line_length=100. The symbol was never referenced and is not re-exported (xrspatial exposes only diffuse), so removing it changes no behaviour. Records the style-sweep state for diffusion in .claude/sweep-style-state.csv. flake8 and isort both clean; test_diffusion.py 25 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3421.
Style cleanup of
xrspatial/diffusion.pyagainst the project's ownsetup.cfgflake8/isort config (max-line-length=100,line_length=100).Categories addressed
not_implemented_funcimport. The symbol was never referenced in the module and is not part of any re-export (xrspatial/__init__.pyexposes onlydiffuse), so the removal is behaviour-neutral.line_length=100: movedfrom numba import cuda, prangeinto the sorted third-party group and rewrapped thefrom xrspatial.utils import (...)block to the grid style already used infocal.py/slope.py. Dropped one stray blank line. No behaviour change.No Cat 1/2/5 findings were present (no PEP8 E/W codes, no bare except, no mutable defaults, no
== None/True/False, no shadowed builtins).Verification
flake8 xrspatial/diffusion.py— cleanisort --check-only --diff xrspatial/diffusion.py— cleanpytest xrspatial/tests/test_diffusion.py— 25 passedBoth fixes are static and apply uniformly across the numpy / cupy / dask+numpy / dask+cupy backends; no per-backend verification needed. No auto-formatter (black/ruff) was run and the flake8/isort config was not widened.
State tracked in
.claude/sweep-style-state.csv.