Style: clean up dasymetric.py lint (F401, E128, isort)#3411
Open
brendancol wants to merge 2 commits into
Open
Conversation
Remove unused is_dask_cupy import (F401), fix E128 continuation indent in the dask+cupy disaggregate path, and reformat the xrspatial.utils import block to isort's line_length=100 form. No behavior change; all 61 tests in test_dasymetric.py pass and flake8 + isort are clean. Found by the /deep-sweep style sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Style cleanup for
xrspatial/dasymetric.py, found by the/deep-sweepstyle sweep. Three issues, all reported by the project's ownsetup.cfg-configured linters (flake8max-line-length=100, isortline_length=100), neither of which is gated in CI.Categories addressed
is_dask_cupy, imported fromxrspatial.utilsbut never used. grep confirms the only occurrence was the import._disaggregate_dask_numpycall.xrspatial.utilsimport block to the form isort produces atline_length=100.Behavior
No behavior change. The F401 removal drops a symbol that was never referenced (not a re-export). flake8 and isort are clean on the file, and all 61 tests in
test_dasymetric.pypass.