Add memory guards to reproject CuPy paths and output grid#1188
Merged
brendancol merged 1 commit intomasterfrom Apr 13, 2026
Merged
Add memory guards to reproject CuPy paths and output grid#1188brendancol merged 1 commit intomasterfrom
brendancol merged 1 commit intomasterfrom
Conversation
The numpy reproject path had a _MAX_WINDOW_PIXELS guard that caps the source window fetched for each output chunk, preventing OOM when a degenerate projection maps a small output chunk to a huge source area. The CuPy paths were missing this guard. Also adds a _MAX_OUTPUT_PIXELS guard in _compute_output_grid that rejects output grids exceeding 1 billion pixels, preventing a denial-of-service via tiny resolution values on large extents. Fixes #1186, fixes #1187.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_MAX_WINDOW_PIXELSguard to_reproject_chunk_cupy()and_reproject_dask_cupy(), matching the existing guard in the numpy path. Without this, a degenerate projection near a singularity could attempt to load the entire source raster onto the GPU for a single chunk, causing GPU OOM._MAX_OUTPUT_PIXELSguard (1 billion pixels) in_compute_output_grid()that rejects output grids with unreasonable dimensions. Without this, a tinyresolutionparameter on a large extent triggers uncontrolled memory allocation.Fixes #1186, fixes #1187.
Test plan
test_output_grid_too_large_raises-- verifies ValueError for extreme resolutiontest_output_grid_normal_resolution_ok-- verifies normal grids passtest_numpy_chunk_source_window_guard-- verifies basic reproject still workspytest xrspatial/tests/test_reproject.py-- 96 passed