Skip to content

Update deb/RPM packaging scripts: add PHP 8.3–8.5, drop PHP < 7.2#923

Open
Copilot wants to merge 2 commits intomainfrom
copilot/add-php-8-compatibility
Open

Update deb/RPM packaging scripts: add PHP 8.3–8.5, drop PHP < 7.2#923
Copilot wants to merge 2 commits intomainfrom
copilot/add-php-8-compatibility

Conversation

Copy link

Copilot AI commented Mar 17, 2026

The .deb packaging script's Depends list was missing PHP 8.3+ mysql packages and still carried obsolete PHP 5.x/7.0/7.1 dependencies. The RPM spec's minimum version message was similarly stale (PHP 5.4).

Changes

  • utils/wp-cli-updatedeb.shdump_control() Depends line:

    • Removed pre-7.2 PHP packages: php5-cli, php7-cli, php5-mysql, php5-mysqlnd, php7.0-mysql, php7.1-mysql
    • Added php8.3-mysql, php8.4-mysql, php8.5-mysql
    • Simplified CLI dependency to php-cli (Debian metapackage)
    Depends: php-cli, php7.2-mysql | php7.3-mysql | php7.4-mysql | php8.0-mysql | php8.1-mysql | php8.2-mysql | php8.3-mysql | php8.4-mysql | php8.5-mysql | php-mysql, mysql-client | mariadb-client
    
  • utils/wp-cli-rpm.spec — Updated %post message from PHP 5.4PHP 7.2 to match the actual minimum requirement.

Original prompt

This section details on the original issue you should resolve

<issue_title>No PHP 8.2 compatible release of deb archive</issue_title>
<issue_description>Please can you package up and release a PHP 8.2 compatible version of php-wcli_2.8.1_all.deb? Only one change is required, adding | php-mysql to the Depends list. I was able to decompress the current deb file, update Depends in DEBIAN/control, rebuild the package, and then install it on Debian Bookworm, which ships with PHP 8.2 as standard. I haven't tested exhaustively but so far I haven't come across any errors.</issue_description>

<agent_instructions>In utils/wp-cli-updatedeb.sh, add support for PHP 8.3 - 8.5. Drop support for anything below PHP 7.2

Also update utils/wp-cli-rpm.spec to require PHP 7.2+ instead of 5.4</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@danielbachhuber @schlessera Can you rebuild `php-wpcli_2.8.1_all.deb` now that https://github.com//pull/562 is applied? It looks like `php-wpcli_latest_all.deb` is out of date too. @swissspidy Is this issue still relevant? @swissspidy Thanks for the ping. That file could definitely use an update.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add PHP 8.2 compatible release of deb archive Update deb/RPM packaging scripts: add PHP 8.3–8.5, drop PHP < 7.2 Mar 17, 2026
Copilot AI requested a review from swissspidy March 17, 2026 21:04
@swissspidy swissspidy added this to the 3.0.0 milestone Mar 17, 2026
@swissspidy swissspidy marked this pull request as ready for review March 17, 2026 21:06
@swissspidy swissspidy requested a review from a team as a code owner March 17, 2026 21:06
Copilot AI review requested due to automatic review settings March 17, 2026 21:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Debian and RPM packaging metadata to reflect the project’s supported PHP versions and improve installability on newer distributions.

Changes:

  • Updated Debian Depends to drop pre-7.2 explicit packages, use php-cli, and add MySQL extension alternatives up through PHP 8.5.
  • Updated RPM %post output message to state PHP 7.2+ instead of PHP 5.4+.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
utils/wp-cli-updatedeb.sh Refreshes generated DEBIAN/control dependencies to remove obsolete PHP packages and add newer MySQL extension alternatives.
utils/wp-cli-rpm.spec Updates the post-install message to reflect the intended minimum PHP version.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Section: php
Priority: optional
Depends: php5-cli (>= 5.6) | php-cli | php7-cli, php5-mysql | php5-mysqlnd | php7.0-mysql | php7.1-mysql | php7.2-mysql | php7.3-mysql | php7.4-mysql | php8.0-mysql | php8.1-mysql | php8.2-mysql | php-mysql, mysql-client | mariadb-client
Depends: php-cli, php7.2-mysql | php7.3-mysql | php7.4-mysql | php8.0-mysql | php8.1-mysql | php8.2-mysql | php8.3-mysql | php8.4-mysql | php8.5-mysql | php-mysql, mysql-client | mariadb-client
Comment on lines 11 to 13
%post
echo "PHP 5.4 or above must be installed."
echo "PHP 7.2 or above must be installed."

@wojsmol
Copy link
Contributor

wojsmol commented Mar 17, 2026

cc @szepeviktor Please double-check the changes.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request scope:distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No PHP 8.2 compatible release of deb archive

4 participants