Skip to content

Fix newly reported PHPStan error#614

Merged
swissspidy merged 1 commit intomainfrom
fix/phpstan
Apr 29, 2026
Merged

Fix newly reported PHPStan error#614
swissspidy merged 1 commit intomainfrom
fix/phpstan

Conversation

@swissspidy
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 07:26
@swissspidy swissspidy requested a review from a team as a code owner April 29, 2026 07:26
@github-actions github-actions Bot added the bug label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a newly reported PHPStan issue in User_Meta_Command by removing an inline PHPStan suppression that is no longer needed (and can itself become an error when PHPStan is configured to report unused/unmatched ignores).

Changes:

  • Removed a now-unnecessary @phpstan-ignore return.type suppression and related TODO comments from replace_login_with_user_id().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a TODO comment and a PHPStan ignore annotation from the replace_login_with_user_id method in src/User_Meta_Command.php. I have no feedback to provide as there are no review comments.

@swissspidy swissspidy added this to the 2.8.11 milestone Apr 29, 2026
@swissspidy swissspidy added the scope:testing Related to testing label Apr 29, 2026
@swissspidy swissspidy merged commit 50cf8fc into main Apr 29, 2026
81 checks passed
@swissspidy swissspidy deleted the fix/phpstan branch April 29, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants