Use refcount on DER buffer to prevent UAF#10860
Open
padelsbach wants to merge 2 commits into
Open
Conversation
fe69630 to
f95714f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a use-after-free when the certificate is updated in the SNI callback (triggered by the clienthello). The certificate and certChain buffer are pointed to by both the
WOLFSSLobject and theWOLFSSL_CTXobject, and a call towolfSSL_CTX_use_certificate_file()triggers a free+null of the pointers in CTX but not the SSL object.Observable failure is an ASAN read failure in
wolfSSL_accept_TLSv13. RequiresHAVE_SNIenabled.Fix is to add reference counter on the shared
DerBuffer.Fixes zd 22107.
Testing
TDD using new unit test.
Checklist