Check SNI/ALPN in TLS 1.2 stateful session ID resumption#10489
Open
holtrop-wolfssl wants to merge 1 commit into
Open
Check SNI/ALPN in TLS 1.2 stateful session ID resumption#10489holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
|
holtrop-wolfssl
force-pushed
the
zd21798
branch
4 times, most recently
from
e312881 to
9a67c0d
Compare
Contributor
Author
|
retest this please (build hung) |
julek-wolfssl
requested changes
May 20, 2026
Member
julek-wolfssl
left a comment
julek-wolfssl
left a comment
There was a problem hiding this comment.
Does this check get performed for TLS 1.3 already? If you extend it with stateless ticket support then that should also be tested in test_tls.c.
| #if defined(HAVE_SESSION_TICKET) && \ | ||
| (defined(HAVE_SNI) || defined(HAVE_ALPN)) | ||
| /* Do not resume session if sniHash/alpnHash do not match. */ | ||
| if (!ssl->options.useTicket) { |
Member
There was a problem hiding this comment.
Why only do these checks on !ssl->options.useTicket? Some settings restore the session from the cache even when using tickets. If we want to do this check on stateless tickets we can add it to the InternalTicket struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21798
Testing
How did you test?
Checklist