Add sz check to ChachaAEADDecrypt to prevent potential underflow.#10125
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Apr 6, 2026
Merged
Add sz check to ChachaAEADDecrypt to prevent potential underflow.#10125douzzer merged 1 commit intowolfSSL:masterfrom
douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
Thanks to Zou Dikai for the report.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an input-size guard in ChachaAEADDecrypt to prevent sz - aead_mac_size from underflowing when the ciphertext is shorter than the authentication tag, addressing zd#21521.
Changes:
- Initialize
msgLendefensively before computing it. - Add an early-return check for
sz < ssl->specs.aead_mac_sizeto avoid underflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#21521
Thanks to Zou Dikai for the report.
Testing
Built in tests
Checklist