Add missing definition ML_DSA_KEYGEN_SEED_LENGTH.#105
Merged
dgarske merged 1 commit intoMay 5, 2026
Merged
Conversation
roberthdevries
force-pushed
the
missing-definition-ML_DSA_KEYGEN_SEED_LENGTH
branch
from
67aef86 to
a114bca
Compare
JeremiahM37
approved these changes
Apr 20, 2026
dgarske
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class method
make_key_from_seed()ofMlDsaPrivateuses the undefined variableML_DSA_KEYGEN_SEED_LENGTH.This patch adds this variable and adds a unit test for the class method.