monolithic self-update optimizations#743
Conversation
There was a problem hiding this comment.
Pull request overview
This PR streamlines monolithic self-update builds by removing swap/backup-based update machinery, simplifying the monolithic boot flow, and expanding simulator/CI coverage to validate monolithic self-update behavior (including optional self-header persistence).
Changes:
- Force-disable swap/backup in monolithic self-update builds and compile out swap-based update code paths.
- Simplify monolithic boot failure behavior (panic instead of swap/fallback update flow) and add compile-time incompatibility guards.
- Update simulator configuration sizing and add/extend simulator tests + CI steps for monolithic self-update (including self-header persistence).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/test.mk | Removes swap partition creation for monolithic test; adds a new simulator test validating persisted self-header bytes. |
| src/update_flash.c | Compiles out swap-based update machinery for monolithic mode and removes emergency update flow when boot verification fails. |
| options.mk | Forces DISABLE_BACKUP=1 for monolithic self-update; tweaks swap address defaults when backup is disabled. |
| include/wolfboot/wolfboot.h | Adds compile-time guards to enforce monolithic self-update prerequisites and incompatibilities. |
| config/examples/sim-self-update-monolithic.config | Increases partition sizing and removes swap partition address for monolithic simulator config. |
| Makefile | Makes swap region assembly conditional when backup is disabled. |
| .github/workflows/test-sim-self-update.yml | Adds CI steps for monolithic self-update test targets, including self-header persistence verification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #743
Scan targets checked: wolfboot-bugs, wolfboot-src
No new issues found in the changed files. ✅
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DISABLE_BACKUP=1, eliminating the swap partition and all swap-based update code (wolfBoot_copy_sector, wolfBoot_update, etc.) and partition state checks from monolithic builds, since they were unused