Fixes CD disk stacks

[BingusSS13]

Trying to use the other stacks on CD disks is like completely broken.

Large disk, you can't use the fourth stack.
Medium disk, you can't use the first and fourth stack.
Small disk, you can only use the third stack.

This will (hopefully) fix that issue.
I've tested this with different disk models like circle4x4 and it seems to work fine.

[BingusSS13]

I might be a bit stupid because it genuinely took me a day to figure this out

[AlexALX]

this fixes only usage of tracks or also alters what disk report in reader information? because not sure if this change will broke cd drive in my alx e2 pc & os as well.

[BingusSS13]

im not entirely sure if it would break your cd drive or not but you can download my branch and test it if you'd like to

[Astralcircle]

@AlexALX yea, it would be great if this was tested, my main concern is that this PR could break something

[BingusSS13]

Maybe I could add a "legacy mode" input to the CD ray that switches it to use the old logic for CD stacks?

[thegrb93]

It would be helpful if there was a diagram showing what changed. If the old behavior didn't even work then there's no point in supporting it.

[BingusSS13]

This is the OBB, which the old behavior uses for StackStartHeight. There's extra space on the top and bottom of the OBB.
This is a problem because we're using a trace for the hit position, and I believe traces use AABBs (or some other type of bounding box), which do not have this extra space. This messes with the old behavior for disk stacks.

Here is the AABB:

[BingusSS13]

old behavior

[BingusSS13]

new behavior

[AlexALX]

Can you remind me how we change stacks when we need read for example stack 3 ? in my system i have two sides reader, one on bottom, one on top, and reading stacks, but not remember how

[BingusSS13]

Can you remind me how we change stacks when we need read for example stack 3 ? in my system i have two sides reader, one on bottom, one on top, and reading stacks, but not remember how

You have to lower the ray emitter into the disk

[Astralcircle]

So this does change the broken behavior. You need to add a Legacy setting that will be disabled by default on new cd disks

[BingusSS13]

So this does change the broken behavior. You need to add a Legacy setting that will be disabled by default on new cd disks

Should this be an option when creating the cd ray or a wire input?
I feel like it should be a wire input, but I just want to be sure.

Also, what should I name the option? "LegacyStacks"?

[thegrb93]

I'm against supporting the legacy behavior. People can update their dupes.

[AlexALX]

well, just need to test this change in some free day to see how it works... but if it broke for example "dual-side" reading behavior then thats huge change.. + moving vertically cd ray another hard part for automated work like on my pc