refactor: add AppendOnlyStackedSet iteration support and tests#20560
Open
refactor: add AppendOnlyStackedSet iteration support and tests#20560
Conversation
|
Contributor
|
This PR is packaged and the instant preview is available (ad1cc74). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@ad1cc74
yarn add -D webpack@https://pkg.pr.new/webpack@ad1cc74
pnpm add -D webpack@https://pkg.pr.new/webpack@ad1cc74 |
Merging this PR will improve performance by 29.63%
Performance Changes
Comparing 
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce?
Fix an issue where
this._currentcould retain a reference to a cleared set after callingAppendOnlyStackedSet.clear(), which might cause unexpected bugs. Also add tests forAppendOnlyStackedSet.Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
No
Use of AI
No