Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
robert3005
approved these changes
Feb 13, 2026
Comment on lines
+160
to
+162
| // The result of precondition may return another ScalarFn, in which case we should | ||
| // apply it immediately. | ||
| return result.execute::<ArrayRef>(ctx); |
Contributor
There was a problem hiding this comment.
do an optimize first?
Contributor
There was a problem hiding this comment.
also can we add a BIG todo to remove this once we have a better driver check?
Merged
a10y
added a commit
that referenced
this pull request
Feb 13, 2026
Forgot to address #6503 (comment) Signed-off-by: Andrew Duffy <andrew@a10y.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR closes an open issue or discussion?
Closes #6496
What changes are included in this PR?
fill_null scalar fn execution will execute() its precondition result. In this case, the precondition was returning an unexecuted
CastArraywhich breaks the assumption that ScalarFn::execute() always makes forward progress towardColumnar