refactor: make reporter traits and writers synchronous#269
Merged
branchseer merged 3 commits intomainfrom Mar 18, 2026
Merged
Conversation
Replace async_trait on GraphExecutionReporter and LeafExecutionReporter with plain sync traits. Switch StdioConfig writers and spawn_with_tracking writer params from tokio AsyncWrite to std::io::Write. Child process stdout/stderr reading remains async via tokio::select, but all reporter callbacks and output writing are now synchronous. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async_traitfromGraphExecutionReporterandLeafExecutionReportertraits, making all reporter callbacks synchronousStdioConfigwriters andspawn_with_trackingwriter params fromtokio::io::AsyncWritetostd::io::Write#[tokio::test] asyncto plain#[test]Child process stdout/stderr reading remains async via
tokio::select!, but all reporter callbacks and output writing are now synchronous.Test plan
cargo check -p vite_taskcompiles cleanlycargo check -p vite_task_bincompiles cleanlycargo test -p vite_task -- reporter)🤖 Generated with Claude Code