Conversation
On Windows, `path.join` and `path.normalize` produce backslash-separated paths (e.g., `packages\core`). When passed as CLI arguments to external commands like `create-vite`, the backslash gets lost, creating `packagescore` instead of `packages/core`. Normalize all relative target directory paths to forward slashes at the source: in `formatTargetDir()` and in `bin.ts` path joins. Closes #938
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
path.joinandpath.normalizeproduce backslash-separatedpaths (e.g.,
packages\core). When passed as CLI arguments to externalcommands like
create-vite, the backslash gets lost, creatingpackagescoreinstead ofpackages/core.Normalize all relative target directory paths to forward slashes at the
source: in
formatTargetDir()and inbin.tspath joins.Closes #938