fix(env): check all shell profiles in vp env doctor#967
Closed
zerone0x wants to merge 1 commit intovoidzero-dev:mainfrom
Closed
fix(env): check all shell profiles in vp env doctor#967zerone0x wants to merge 1 commit intovoidzero-dev:mainfrom
vp env doctor#967zerone0x wants to merge 1 commit intovoidzero-dev:mainfrom
Conversation
`check_profile_files` only checked `.zshenv` + `.profile` on macOS and `.profile` on Linux, but the install script writes to `.zshenv`, `.zshrc`, `.bash_profile`, `.bashrc`, and `.profile`. This caused doctor to report missing IDE integration even when everything was correctly configured. Unify the profile list to match install.sh and implode.rs. Closes voidzero-dev#881 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
There is already a similar PR fixing this issue #961 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_profile_filesonly checked.zshenv+.profileon macOS and.profileon Linuxinstall.shwrites to all of:.zshenv,.zshrc,.bash_profile,.bashrc,.profilevp env doctorto falsely report missing IDE integration on Linux with zsh (env in.zshrc) or bash (env in.bashrc)install.shandimplode.rs, removing the platform-specific#[cfg]branchesTest plan
vp env doctoron Linux with env sourced from.bashrcno longer shows false warningvp env doctoron macOS with env sourced from.zshrcno longer shows false warningvp env doctorstill detects when no profile has the env sourcing lineCloses #881
🤖 Generated with Claude Code