lib: add file locking to downloads#675
Open
Duncaen wants to merge 2 commits intovoid-linux:masterfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/download.c
Dismissed
| free(tempfile); | ||
|
|
||
| if (lockfd != -1) | ||
| release_lock(lockfile, lockfd); |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
Member
Author
There was a problem hiding this comment.
intended in case locking becomes optional, doesn't really make sense for every download.
Usually the files in the cache directory are protected by the pkgdb write lock. But if xbps-install uses separate root directories but shared cache directories there needs to be extra locking to avoid file corruption.
Duncaen
force-pushed
the
part-locking
branch
from
011f100 to
f186933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually the files in the cache directory are protected by the pkgdb write lock. But if xbps-install uses separate root directories but shared cache directories there needs to be extra locking to avoid file corruption.