z3: fix empty libz3.so on musl targets and revbump llvm#61400
Open
hystericca wants to merge 1 commit into
Open
z3: fix empty libz3.so on musl targets and revbump llvm#61400hystericca wants to merge 1 commit into
hystericca wants to merge 1 commit into
Conversation
hystericca
changed the title
hystericca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the template uses
vmove usr/lib/libz3.so, it only moves the symlink. The actual versioned shared binaries are left behind, which causes the build server to package a literal 0-byte empty library file.This completely broke the entire LLVM toolchain on
aarch64-musl(clang,clangd, etc.), aslibLLVM.soattempts to load the empty Z3 library and instantly crashes withsymbol not foundTesting the changes
Local build testing