element-desktop: update to 1.12.21.#60941
Open
ErenHDE wants to merge 1 commit into
Open
Conversation
Duncaen
requested changes
Jun 7, 2026
Duncaen
left a comment
Duncaen
left a comment
Member
There was a problem hiding this comment.
We generally do not want to vendor desktop files. Was it removed from the repo?
Contributor
Author
|
Yes, I checked the repo and it's not there. |
Member
|
electron apps will generate the desktop file during build sometimes https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/testing/element-desktop/APKBUILD#L169 |
Contributor
Author
|
I checked again but I couldn't find the desktop file. |
ErenHDE
force-pushed
the
element-desktop-1.12.20
branch
from
95948a8 to
13fcaaa
Compare
ErenHDE
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing