Skip to content

godot: update to 4.6.2, add godot-export-templates subpakage, adopt#58117

Open
zen0bit wants to merge 1 commit intovoid-linux:masterfrom
oSoWoSo:godot
Open

godot: update to 4.6.2, add godot-export-templates subpakage, adopt#58117
zen0bit wants to merge 1 commit intovoid-linux:masterfrom
oSoWoSo:godot

Conversation

@zen0bit
Copy link
Copy Markdown
Contributor

@zen0bit zen0bit commented Dec 7, 2025

Testing the changes

  • I tested the changes in this PR: yes

Local build testing

  • I built this PR locally for my native architecture, (x64 glibc)

@Rutpiv
Copy link
Copy Markdown
Contributor

Rutpiv commented Dec 8, 2025

Hi! I’m currently updating Godot as part of the Vulkan stack update in my PR:
#56439

Godot isn’t tied to the new glslang version yet, but once glslang is updated we’ll still need to revbump and rebuild Godot.
Handling the update in the same flow avoids doing two separate build cycles and keeps everything consistent.

If you’d like, I can add you as a co-author of the Godot update commit and also list you as the package maintainer in my PR, since I don’t plan to maintain the package myself.
Just let me know and I’ll update it.

Thanks for working on this!

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Dec 8, 2025

@Rutpiv
yes

PS: Thinking if tpz (templates for export for Godot projects) should be also added as package/subpackage

But..
They are expected in "$HOME/.local/share/godot/export_templates/${version}/"

not tried if /usr/share will work
🤔

@Rutpiv
Copy link
Copy Markdown
Contributor

Rutpiv commented Dec 9, 2025

I’ve only worked with export templates a few times in past projects, and when I needed them, I always installed them directly through the editor.
But your idea makes sense, and I think we can support it cleanly in Void.

One option is to create a godot-export-templates subpackage together with a build option that enables or disables downloading the .tpz file. This way, anyone building the package who doesn’t want to download the templates (which are relatively large) can simply disable that option.

Regarding the install path:
Godot expects templates under:

$HOME/.local/share/godot/export_templates/${version}/

I ran a quick test on my machine:
I downloaded the .tpz, created:

/usr/share/godot/export_templates/${version}/

extracted the contents there, and then created a symlink with:

doas ln -s /usr/share/godot/export_templates ~/.local/share/godot

After that, Godot immediately recognized the templates and I was able to export a project without any issues.
So /usr/share works fine, as long as the user creates the symlink.

About automating this:
I’m not entirely sure about Void’s policies regarding writing directly to a user’s $HOME from a package template.
Technically, it would be possible to create the directory and the symlink automatically, but since the package is installed system-wide (as root) and there may be multiple users on the machine, I’m not sure whether that would be allowed or considered correct.
It might be something worth discussing.

If this approach sounds good, we can prototype the subpackage + optional download and include it in the PR.
If you have any thoughts on this approach or prefer a different direction, I’m happy to help however I can.

By the way, I’ve added you as a co-author in the Godot commit and set you as the maintainer, as agreed.

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Dec 9, 2025

About automating this:
I’m not entirely sure about Void’s policies regarding writing directly to a user’s $HOME from a package template.

That's exactly why I asked..

Maybe just add mention of symlinking to install msg?

@Rutpiv
Copy link
Copy Markdown
Contributor

Rutpiv commented Dec 9, 2025

That makes sense. I checked the manual and subpackages can indeed have their own INSTALL.msg file:

srcpkgs/<pkgname>/<subpkg>.INSTALL.msg

So we can show the symlink instructions only when installing godot-export-templates, without affecting the main godot package.

@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Dec 9, 2025

already did that, not yet in PR...

@zen0bit zen0bit force-pushed the godot branch 3 times, most recently from 4735df0 to e7a5562 Compare December 22, 2025 17:03
@ahesford
Copy link
Copy Markdown
Member

Don't duplicate work with another PR, and don't try to make an end-run around the build process to save revbump. It makes review and approval more difficult and creates conflicts.

Reconcile whether you two want to move forward with a single PR and close the other, or restore this to a simple update independent of the other work.

@ahesford ahesford marked this pull request as draft December 30, 2025 17:41
@github-actions
Copy link
Copy Markdown

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 31, 2026
@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Mar 31, 2026

dormant

Requires glslang from #56439 ❤️ merged

We can 't update Godot without it

@github-actions github-actions bot removed the Stale label Apr 1, 2026
@zen0bit zen0bit marked this pull request as ready for review April 1, 2026 21:23
@zen0bit zen0bit changed the title godot: update to 4.5.1, adopt godot: update to 4.6.2, adopt Apr 2, 2026
@zen0bit
Copy link
Copy Markdown
Contributor Author

zen0bit commented Apr 2, 2026

🚀
Looks good to me

Copy link
Copy Markdown
Contributor

@Rutpiv Rutpiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this PR locally, built it on x86_64-glibc, and tested it. Opened a few older projects and everything worked fine. I also tested the new export templates package, followed the linking instructions from the install message, exported a project successfully. Template looks good to me as well. Everything LGTM. Thanks for the collaboration on this, I learned a lot working with you on these PRs. Great work!

@zen0bit zen0bit changed the title godot: update to 4.6.2, adopt godot: update to 4.6.2, add godot-export-templates subpakage, adopt Apr 13, 2026
Co-authored-by: Roger Freitas Pereira <roger_freitas@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants