godot: update to 4.6.2, add godot-export-templates subpakage, adopt#58117
godot: update to 4.6.2, add godot-export-templates subpakage, adopt#58117zen0bit wants to merge 1 commit intovoid-linux:masterfrom
Conversation
|
Hi! I’m currently updating Godot as part of the Vulkan stack update in my PR: Godot isn’t tied to the new glslang version yet, but once glslang is updated we’ll still need to revbump and rebuild Godot. If you’d like, I can add you as a co-author of the Godot update commit and also list you as the package maintainer in my PR, since I don’t plan to maintain the package myself. Thanks for working on this! |
|
@Rutpiv PS: Thinking if But.. not tried if /usr/share will work |
|
I’ve only worked with export templates a few times in past projects, and when I needed them, I always installed them directly through the editor. One option is to create a Regarding the install path: I ran a quick test on my machine: extracted the contents there, and then created a symlink with: After that, Godot immediately recognized the templates and I was able to export a project without any issues. About automating this: If this approach sounds good, we can prototype the subpackage + optional download and include it in the PR. By the way, I’ve added you as a co-author in the Godot commit and set you as the maintainer, as agreed. |
That's exactly why I asked.. Maybe just add mention of symlinking to install msg? |
|
That makes sense. I checked the manual and subpackages can indeed have their own So we can show the symlink instructions only when installing |
|
already did that, not yet in PR... |
4735df0 to
e7a5562
Compare
|
Don't duplicate work with another PR, and don't try to make an end-run around the build process to save revbump. It makes review and approval more difficult and creates conflicts. Reconcile whether you two want to move forward with a single PR and close the other, or restore this to a simple update independent of the other work. |
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Requires glslang from #56439 ❤️ merged We can |
|
🚀 |
There was a problem hiding this comment.
I pulled this PR locally, built it on x86_64-glibc, and tested it. Opened a few older projects and everything worked fine. I also tested the new export templates package, followed the linking instructions from the install message, exported a project successfully. Template looks good to me as well. Everything LGTM. Thanks for the collaboration on this, I learned a lot working with you on these PRs. Great work!
Co-authored-by: Roger Freitas Pereira <roger_freitas@live.com>
Testing the changes
Local build testing