Skip to content

fix(vks): --secondary-subnets takes CIDRs, not subnet IDs #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vks-team wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(vks): --secondary-subnets takes CIDRs, not subnet IDs #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions docs/commands/vks/create-cluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,11 @@ Availability-zone strategy for the cluster.

**`--secondary-subnets`** (list<string>)

Secondary subnet IDs, comma-separated. Used by `CILIUM_NATIVE_ROUTING`.
Secondary subnet **CIDRs**, comma-separated — the address ranges themselves, **not** subnet IDs (`sec-sub-…`). Used by `CILIUM_NATIVE_ROUTING`.

- Required: Conditional — at least one value is required when `--network-type` is `CILIUM_NATIVE_ROUTING`.
- Constraints: up to 10 entries.
- Syntax: `sub-aaa,sub-bbb`
- Syntax: `10.5.60.0/22,10.5.71.0/26`

**`--node-netmask-size`** (integer)

Expand Down Expand Up @@ -217,7 +217,7 @@ grn vks create-cluster \
--vpc-id net-abc12345-0000-0000-0000-000000000001 \
--subnet-id sub-abc12345-0000-0000-0000-000000000001 \
--node-netmask-size 25 \
--secondary-subnets sub-abc12345-0000-0000-0000-000000000002
--secondary-subnets 10.5.60.0/22,10.5.71.0/26
```

Create a cluster with TIGERA (CIDR required) and auto-healing:
Expand All @@ -242,6 +242,6 @@ grn vks create-cluster \
--network-type CILIUM_NATIVE_ROUTING \
--vpc-id net-abc12345-0000-0000-0000-000000000001 \
--node-netmask-size 25 \
--secondary-subnets sub-abc12345-0000-0000-0000-000000000002 \
--secondary-subnets 10.5.60.0/22,10.5.71.0/26 \
--dry-run
```
2 changes: 1 addition & 1 deletion go/cmd/vks/create_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func init() {
f.String("block-store-csi-plugin", "enabled", "Block store CSI plugin (enabled, disabled)")
f.String("service-endpoint", "disabled", "Service endpoint (enabled, disabled)")
f.String("az-strategy", "SINGLE", "Availability zone strategy")
f.String("secondary-subnets", "", "Secondary subnet IDs, comma-separated (required for CILIUM_NATIVE_ROUTING, at least one, max 10)")
f.String("secondary-subnets", "", "Secondary subnet CIDRs, comma-separated, e.g. 10.5.60.0/22 (required for CILIUM_NATIVE_ROUTING, at least one, max 10). NOT subnet IDs")
f.String("list-subnet-ids", "", "Subnet IDs for the cluster (comma-separated)")
f.Int("node-netmask-size", 0, "Node netmask size: 24, 25, or 26 (required for CILIUM_NATIVE_ROUTING)")
f.String("auto-upgrade-config", "", "Auto-upgrade config (shorthand time=03:00,weekdays=Mon or JSON; use JSON for multiple weekdays)")
Expand Down
Loading