fix: defer logs RPC call until client is authorized#227
Merged
Conversation
Skip querying logs:list before client trust is established. The trust request (requestTrust) is async and completes in the background. Meanwhile, useLogs() fires synchronously on component mount, causing an unauthorized RPC error. Guard the initial updateLogs() call with ensureTrusted(), matching the pattern used by shared state. Also guard the logs:updated handler to prevent server pushes from triggering queries while untrusted. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents unauthorized RPC errors when connecting to DevTools. The client trust request fires asynchronously in the background, but
useLogs()was callingdevtoolskit:internal:logs:listsynchronously on component mount, before trust was established. This caused "Unauthorized access" errors.Now guards the initial logs query with
ensureTrusted(), matching the pattern used by shared state. Also guards the server-push handler to prevent logs:updated events from triggering unauthorized calls.Changes
updateLogs()call untilensureTrusted()resolveslogs:updatedRPC handler to skip updates while untrusted🤖 Generated with Claude Code