Open
Conversation
Expose an optional `className` prop on `<MapControl>` so users can style the control container element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
classNameprop to<MapControl>so users can style the control container element. SinceMapControlrenders its children into a detached<div>viacreatePortal(which is then handed to the Maps JavaScript API and positioned by the control-layout algorithm), there is currently no way for consumers to target that wrapping element from the React tree - the new prop closes that gap.The implementation mirrors the existing
classNamehandling in sibling components (AdvancedMarker,InfoWindow): an effect syncs the prop to the DOM node ascontrolContainer.className = className ?? ''.Changes
src/components/map-control.tsx— add optionalclassNameprop and auseEffectthat syncs it to the portal container.src/components/__tests__/map-control.test.tsx— add unit tests covering initial application, updates, and unset/removal ofclassName.docs/api-reference/components/map-control.md— document the new prop under an "Optional" section.Test plan
npm run test:linterpassesnpm run test:prettierpassesnpm run test:tscpassesnpm run test:unit -- map-control— 3/3 tests pass (1 existing + 2 new)npm run test:unitsuite: no new failures introduced (pre-existingts-jestfailures onmainare unrelated to this change)Notes for reviewers
classNameon other components in the library for consistency.