Add support to native Windows ARM64 with fallback to Win64#419
Add support to native Windows ARM64 with fallback to Win64#419micha102 wants to merge 1 commit intovideolan:3.xfrom
Conversation
Wrap Windows ARM64 detection in #if !NET40 && !NETSTANDARD1_1 to fix CI running on NET40
|
I added detection of CPU and Bitness for Windows when .NET is greater than 4.0 The thing is if I implement the detection with .NET 4.0, then I need to use Windows specific code. So, in Directory.Build.props, need to add a tag for WINDOWS (there's a WINDOWS_MODERN tag for UWP so that's good) Then, in PlatformHelper.cs, need to add And finally I can do Core.cs a simple But since, Windows ARM64 is newly supported, I don't think it's worth it to implement detection for .NET 4.0 Let me know if it's OK, or I must implement it for .NET 4.0 too. |
Description of Change
Add support to native Windows ARM64 with fallback to Win64.
It allows LibVLCSharp to detect win-arm64 in Core.cs and add fallback to win-x64 folders to preserve compatibility.
It complements mfkl/libvlc-nuget#53 and corresponding PR , which added ARM64 binaries, allowing WPF apps on Windows ARM devices to load LibVLC natively.
Issues Resolved
API Changes
Added:
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
git clone https://github.com/micha102/libvlcsharp.git
exclude Android, iOS and few others
dotnet pack src/LibVLCSharp/LibVLCSharp.csproj -c Win32Release
dotnet pack src/LibVLCSharp.WPF/LibVLCSharp.WPF.csproj -c Win32Release
PR Checklist