fix:multi-plane support

[ashish-066]

No description provided.

[ashish-066]

@mfkl can you look into this and share your opinion?

[mfkl]

it does not build

[mfkl]

Multi plane access is actually already possible through the use of Unsafe.Add but we can add your approach as a clearer/convenience method. You need to update VideoFormatCallback to handle both callbacks path and then it should be fine. you could name the callback LibVLCVideoMultiPlaneFormatCb.

[mfkl]

approach works, few changes to make before merging. If you want to add a test or sample showing its use, much welcome

[ashish-066]

@mfkl can you review the changes

[mfkl]

did you use an AI for this?

[mfkl]

correct fix, but API break

[ashish-066]

correct fix, but API break

You are right I made this change is that the native libVLC signature for the cleanup callback is void (*cleanup)(void *opaque). According to the libVLC headers, the parameter is passed as void *opaque, which maps to IntPtr in .NET rather than ref IntPtr.

https://code.videolan.org/videolan/vlc/-/blob/master/include/vlc/libvlc_media_player.h

Using ref IntPtr would correspond to void**, which doesn't match the native API.

[ashish-066]

i will change it

[mfkl]

did you actually test the interop works? In a sample or unit test?

[ashish-066]

did you use an AI for this?

no