Fix: Correct malformed dashboard statistics update script#290
Closed
pyob-bot wants to merge 9 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request addresses a critical issue in the
src/pyob/dashboard_html.pyfile where the JavaScriptupdateStatsfunction was malformed and prematurely closed its script block.Specifically, this change:
setIntervaland initialupdateStats()calls, which were causing script termination issues.updateStatsas anasyncJavaScript function.fetchcall to the/api/statsendpoint to retrieve real-time dashboard data.setIntervaland initialupdateStats()calls will be correctly placed after the full function definition.Technical Impact
Before this change:
The dashboard's real-time statistics (e.g., iteration count, ledger symbols, queue length) were likely not updating or were failing due to JavaScript errors. The malformed
updateStatsfunction and the premature</script>tag prevented the proper execution of the update logic.After this change:
This fix resolves the underlying JavaScript error by correctly structuring the
updateStatsfunction. Once the function is fully defined and its execution triggers (viasetIntervaland an initial call, as indicated by the comments), the dashboard will reliably fetch and display up-to-date operational statistics. This significantly improves the dashboard's functionality and provides accurate, real-time visibility into the system's state.