Refactor: Simplify API data serialization for patch review#289
Closed
Refactor: Simplify API data serialization for patch review#289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This change refactors the
StatsUpdaterclass by simplifying how data is prepared for the/api/review_patchendpoint. Specifically, the explicitjson.dumps()call for thedatapayload has been removed. Thefetch_apifunction now directly receives a Python dictionary, allowing it to handle the JSON serialization internally.Technical Impact
fetch_apiutility (or the underlying HTTP client it uses) is capable of automatically serializing dictionary payloads to JSON forPOSTrequests. This avoids potential double-serialization or incorrect content-type headers iffetch_apiwas already designed to handle dictionary inputs.fetch_apiacross the codebase, aligning with best practices where the HTTP client manages serialization./api/review_patchendpoint remains identical, ensuring no change in API behavior or data format.