Skip to content

Refactor: Use addEventListener for remove button click handler#287

Closed
pyob-bot wants to merge 6 commits intomainfrom
pyob-evolution-v11-1778310164
Closed

Refactor: Use addEventListener for remove button click handler#287
pyob-bot wants to merge 6 commits intomainfrom
pyob-evolution-v11-1778310164

Conversation

@pyob-bot
Copy link
Copy Markdown
Collaborator

@pyob-bot pyob-bot commented May 9, 2026

Summary of Changes

This pull request updates the event handling mechanism for the 'remove' button within the dashboard's queue items. The onclick property has been replaced with addEventListener('click', ...) to attach the handler for removing a queue item.

Technical Impact

  • Modern Event Handling: Transitions to the recommended and more flexible addEventListener API for attaching event handlers in JavaScript.
  • Improved Maintainability: addEventListener allows for better separation of concerns by detaching event registration from direct property assignment, making the code cleaner and easier to manage.
  • Consistency: Promotes a consistent pattern for event handling across the codebase, aligning with modern JavaScript best practices.
  • No Functional Change: This change is purely an internal refactor and does not alter the user-facing functionality or behavior of the remove button. The button will continue to remove items from the queue as before.

@vicsanity623 vicsanity623 deleted the pyob-evolution-v11-1778310164 branch May 11, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants