Refactor: Extract JavaScript logic to separate file#285
Closed
Refactor: Extract JavaScript logic to separate file#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The JavaScript logic in
src/pyob/dashboard_html.pyhas been refactored to improve maintainability and organization. A new scriptdashboard_utils.jshas been introduced to hold the majority of the JavaScript code, reducing the complexity of thedashboard_html.pyfile.Technical Impact
The changes made in this pull request have the following technical impacts:
dashboard_html.pyby extracting JavaScript logic to a separate filedashboard_utils.jsto hold the extracted JavaScript codesetManualTargetto handle setting the manual target file via API call