Test workflow preview tarballs (aee5699) across examples#44
Draft
pranaygp wants to merge 1 commit into
Draft
Conversation
Switches every example from workflow@4.2.4 to the preview tarballs at https://workflow-tarballs-h3imyuw9g.labs.vercel.dev (workflow@5.0.0-beta.4-aee5699) to validate the upcoming release against existing examples. Also: - Adapt flight-booking-app/postgres instrumentation.ts to the new async getWorld() signature. - Switch postgres from bun to pnpm — bun cannot resolve transitive HTTP-tarball deps (e.g. workflow → @workflow/utils via tarball URL). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps every example from
workflow@4.2.4(npm) to the preview tarballs at https://workflow-tarballs-h3imyuw9g.labs.vercel.dev (built fromvercel/workflow@aee5699, published asworkflow@5.0.0-beta.4-aee5699). Goal: validate the upcoming SDK release against the existing example projects.This PR also includes:
getWorld()is now async — adaptedflight-booking-app/instrumentation.tsandpostgres/instrumentation.tstoawait getWorld()before calling.start?.().workflowtarball depends on@workflow/utilsetc. via tarball URLs, which bun fails to follow).Validation results
Tested install + build + dev + workflow trigger across all 17 examples.
✅ Works end-to-end (workflow triggered, returned 200)
PORTenv varPORTenv varVERCEL_OIDC_TOKEN)❌ Runtime regression — all Next.js 16 examples
All Next-based examples crash at runtime:
Turbopack can't statically analyze a dynamic
await import(handlerPath)inside the new@workflow/core. Verified:nextjs,actors. Likely also affects:ai-sdk-workflow-patterns,birthday-card-generator,flight-booking-app,postgres,rag-agent.❌ Nuxt — RollupError
Standalone
nitroproject works because it pinsnitro@3.0.1-alpha.1; nuxt internally uses Nitro 2.12.9.❌ Build-only — sveltekit
@opentelemetry/api(peer dep) isn't externalized at build. Dev mode works.Pre-existing (not tarball-related)
[NoAdapterInstalled]on buildtsconfig.app.jsonreferences missingsrc/Test plan
/api/signupon hono, sveltekit, astro, tanstack-start, nitro — should return 200@workflow/*deps another wayvercel/workflowfor: turbopack dynamic-import regression, nuxt rollup external collision, sveltekit@opentelemetry/apiresolution🤖 Generated with Claude Code