Skip to content

Test workflow preview tarballs (aee5699) across examples#44

Draft
pranaygp wants to merge 1 commit into
mainfrom
pgp/stepflow-test
Draft

Test workflow preview tarballs (aee5699) across examples#44
pranaygp wants to merge 1 commit into
mainfrom
pgp/stepflow-test

Conversation

@pranaygp

@pranaygp pranaygp commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps every example from workflow@4.2.4 (npm) to the preview tarballs at https://workflow-tarballs-h3imyuw9g.labs.vercel.dev (built from vercel/workflow@aee5699, published as workflow@5.0.0-beta.4-aee5699). Goal: validate the upcoming SDK release against the existing example projects.

This PR also includes:

  • getWorld() is now async — adapted flight-booking-app/instrumentation.ts and postgres/instrumentation.ts to await getWorld() before calling .start?.().
  • postgres switched from bun to pnpm — bun cannot resolve transitive HTTP-tarball deps (the workflow tarball depends on @workflow/utils etc. via tarball URLs, which bun fails to follow).

Validation results

Tested install + build + dev + workflow trigger across all 17 examples.

✅ Works end-to-end (workflow triggered, returned 200)

  • hono — clean
  • nitro (project) — vite warnings about dynamic imports, but trigger works
  • tanstack-start — works
  • sveltekit — works in dev (build fails — see below); ignores PORT env var
  • astro — works in dev (build fails — pre-existing missing adapter); ignores PORT env var
  • ffmpeg-processing — server up; workflow not exercised (needs VERCEL_OIDC_TOKEN)
  • vite (project) — server up; build broken (pre-existing tsconfig issue)

❌ Runtime regression — all Next.js 16 examples

All Next-based examples crash at runtime:

Error: Cannot find module as expression is too dynamic
  at .next/dev/server/chunks/..._@workflow_core_dist_..._.js
  code: 'MODULE_NOT_FOUND'

Turbopack can't statically analyze a dynamic await import(handlerPath) inside the new @workflow/core. Verified: nextjs, actors. Likely also affects: ai-sdk-workflow-patterns, birthday-card-generator, flight-booking-app, postgres, rag-agent.

❌ Nuxt — RollupError

[nitro] ERROR RollupError: "./run.js" is imported as an external by
"@workflow/core/dist/runtime/start.js", but is already an existing non-external module id.

Standalone nitro project works because it pins nitro@3.0.1-alpha.1; nuxt internally uses Nitro 2.12.9.

❌ Build-only — sveltekit

@opentelemetry/api (peer dep) isn't externalized at build. Dev mode works.

Pre-existing (not tarball-related)

  • astro[NoAdapterInstalled] on build
  • vitetsconfig.app.json references missing src/

Test plan

  • CI install across all examples
  • Manual: kick off /api/signup on hono, sveltekit, astro, tanstack-start, nitro — should return 200
  • Decide whether to land the postgres bun→pnpm switch, or keep bun and pin transitive @workflow/* deps another way
  • File upstream issues against vercel/workflow for: turbopack dynamic-import regression, nuxt rollup external collision, sveltekit @opentelemetry/api resolution

🤖 Generated with Claude Code

Switches every example from workflow@4.2.4 to the preview tarballs at
https://workflow-tarballs-h3imyuw9g.labs.vercel.dev (workflow@5.0.0-beta.4-aee5699)
to validate the upcoming release against existing examples.

Also:
- Adapt flight-booking-app/postgres instrumentation.ts to the new async getWorld() signature.
- Switch postgres from bun to pnpm — bun cannot resolve transitive HTTP-tarball
  deps (e.g. workflow → @workflow/utils via tarball URL).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
birthday-card-generator Ready Ready Preview, Comment May 5, 2026 0:09am
flight-booking-app Ready Ready Preview, Comment May 5, 2026 0:09am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant