fix: preserve query string on automatic redirects#232
Open
WilliamK112 wants to merge 1 commit intovercel:mainfrom
Open
fix: preserve query string on automatic redirects#232WilliamK112 wants to merge 1 commit intovercel:mainfrom
WilliamK112 wants to merge 1 commit intovercel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanUrlsandtrailingSlashredirectsProblem
Requests such as
/directory/clean-file.html?foo=barcurrently redirect to/directory/clean-file, dropping the original query string. The same thing happens for automatic trailing slash redirects.Scope
This patch keeps the change narrow on purpose: it preserves the query string only for redirects generated internally by
cleanUrlsandtrailingSlash. It does not change the behavior of user-configuredredirects.Testing
corepack yarn build-viewscorepack yarn jest test/integration.test.js --runInBand --forceExitFixes #178