Skip to content

third-party: update oatpp to 1.3.1#317

Merged
VDanielEdwards merged 2 commits intomainfrom
dev/third-party/oatpp/update-to-1-3-1
Apr 29, 2026
Merged

third-party: update oatpp to 1.3.1#317
VDanielEdwards merged 2 commits intomainfrom
dev/third-party/oatpp/update-to-1-3-1

Conversation

@VDanielEdwards
Copy link
Copy Markdown
Member

@VDanielEdwards VDanielEdwards commented Apr 29, 2026

Subject

Update oatpp to version 1.3.1 which fixes a warning emitted on new-ish GCC versions.

[...]/oatpp/src/oatpp/network/monitor/ConnectionMonitor.cpp: In static member function ‘static void oatpp::network::monitor::ConnectionMonitor::Monitor::monitorTask(std::shared_ptr<oatpp::network::monitor::ConnectionMonitor::Monitor>)’:
[...]/oatpp/src/oatpp/network/monitor/ConnectionMonitor.cpp:146:52: warning:
ignoring return value of ‘std::lock_guard<_Mutex>::lock_guard(mutex_type&) [with _Mutex = std::mutex; mutex_type = std::mutex]’, declared with attribute ‘nodiscard’ [-Wunused-result]

Developer checklist (address before review)

  • Changelog.md updated
  • Prepared update for depending repositories
  • Documentation updated (public API changes only)
  • API docstrings updated (public API changes only)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

@VDanielEdwards VDanielEdwards self-assigned this Apr 29, 2026
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards force-pushed the dev/third-party/oatpp/update-to-1-3-1 branch from c864417 to ef9f07e Compare April 29, 2026 06:05
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
@VDanielEdwards VDanielEdwards added the needs reviewer This issue is looking for a reviewer. label Apr 29, 2026
@VDanielEdwards VDanielEdwards removed the needs reviewer This issue is looking for a reviewer. label Apr 29, 2026
Copy link
Copy Markdown
Contributor

@KonradBreitsprecherBkd KonradBreitsprecherBkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VDanielEdwards VDanielEdwards merged commit 545d1bd into main Apr 29, 2026
15 checks passed
@VDanielEdwards VDanielEdwards deleted the dev/third-party/oatpp/update-to-1-3-1 branch April 29, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants