style: use full paths for internal headers in capi/...#313
Open
VDanielEdwards wants to merge 2 commits intomainfrom
Open
style: use full paths for internal headers in capi/...#313VDanielEdwards wants to merge 2 commits intomainfrom
capi/...#313VDanielEdwards wants to merge 2 commits intomainfrom
Conversation
Collaborator
|
Is there any particular reason you chose the google style guide? I have found that using the llvm style guide leads to headers being more self-contained. |
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
VDanielEdwards
force-pushed
the
dev/refactor/use-full-include-paths-capi
branch
from
d46ede3 to
dda8abe
Compare
Member
Author
No particular reason, it was just the first that came to mind. But I do like the ordering from local -> global as in the LLVM styleguide more than what the Google styleguide suggests. @MariusBgm would you object to switching the include-order to the LLVM styleguide? |
Signed-off-by: Daniel Edwards <Daniel.Edwards@vector.com>
VDanielEdwards
requested review from
snps-behrens
and removed request for
snps-behrens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
Use full paths for internal headers in all sources and headers in
SilKit/source/capi/. Rearranges the includes to follow the guidelines in the LLVM Styleguide for C++Google Styleguide for C++. Removes unneccessary includes.Developer checklist (address before review)