GetParticipantName and GetRegistryUri#165
Open
KonradBreitsprecherBkd wants to merge 9 commits into
Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
34c3665 to
a44c894
Compare
a44c894 to
bd6ae6a
Compare
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
bd6ae6a to
0dc19b1
Compare
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
VDanielEdwards
approved these changes
Jun 22, 2026
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
Signed-off-by: Konrad Breitsprecher <Konrad.Breitsprecher@vector.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dedicated participant string getters
See https://github.com/vectorgrp/sil-kit-planning/issues/62
Summary
This change introduces two dedicated C-API functions:
SilKit_Participant_GetParticipantName(void* outParameterValue, size_t* inOutParameterValueSize, SilKit_Participant* participant)SilKit_Participant_GetRegistryUri(void* outParameterValue, size_t* inOutParameterValueSize, SilKit_Participant* participant)and their C++ equivalents in IParticipant
virtual auto GetParticipantName() const -> std::string = 0virtual auto GetRegistryUri() const -> std::string = 0In addition, string copy/size handling was centralized in the C-API layer and tests were updated/extended accordingly.
Further, the new API is used in the sil-kit-system-controller implementation to dynamically retrieve the participant name (set via command line and/or participant configuration). The name has to be added to the
required participant namesof theworkflow configuration. Without the GetParticipantName functionality, passing a new name by config actually failed because there was no way to retrieve the name from the config programatically.Motivation
The generic
SilKit_Participant_GetParameterAPI in the first draft depended on an enum that looked like it could be expanded to non-string types but actually did not support this. The new design is more simple and exposes the only two relevant participant string parameters directly and clearly. Future parameter queries could be covered by more explicit getters or by retrieving the current participant configuration.Further Notes
CapiParticipant.cpp | CopyStringToOutBuffer: string size query and nulltermination handlingParameterProvider.hpp | QueryString(SilKit_Participant*, StringQueryFunction): Reusable helper to atomically obtain the string that might change between buffer allocation and query.