build,simdjson: export symbols in component build#250
Open
deepak1556 wants to merge 1 commit intov8:node-ci-2026-04-16from
Open
build,simdjson: export symbols in component build#250deepak1556 wants to merge 1 commit intov8:node-ci-2026-04-16from
deepak1556 wants to merge 1 commit intov8:node-ci-2026-04-16from
Conversation
In component builds on POSIX, simdjson.h defines SIMDJSON_DLLIMPORTEXPORT as empty. Combined with Chromium's default -fvisibility=hidden, this causes all simdjson symbols to be hidden in the resulting .so, leading to: ld.lld: error: undefined symbol: simdjson::internal::to_chars(...) ld.lld: error: undefined symbol: simdjson::internal::structural_or_whitespace_negated ld.lld: error: undefined symbol: simdjson::internal::error_codes ld.lld: error: undefined symbol: simdjson::get_active_implementation() Switch the simdjson component to default symbol visibility on POSIX similar to deps/uv.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In component builds on POSIX, simdjson.h defines SIMDJSON_DLLIMPORTEXPORT as empty. Combined with Chromium's default -fvisibility=hidden, this causes all simdjson symbols to be hidden, leading to:
Switch the simdjson component to default symbol visibility on POSIX similar to deps/uv. Addresses the link time failure in https://ci.chromium.org/ui/p/node-ci/builders/try/node_ci_linux64_dbg