Skip to content

ls: check ACL using full path, not bare filename#11812

Draft
sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre:issue-11789
Draft

ls: check ACL using full path, not bare filename#11812
sylvestre wants to merge 2 commits intouutils:mainfrom
sylvestre:issue-11789

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

@sylvestre sylvestre commented Apr 14, 2026

Closes: #11789

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026 •
edited
Loading

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Congrats! The gnu test tests/tail/pipe-f is now passing!

@sylvestre
ls: add regression test for ACL display from different cwd (uutils#11789
9eb8928 
)

When listing a directory containing ACL files from a different cwd,
ls fails to detect ACLs during the width-measuring pass and emits
output with no separator between the `+` marker and the link count
(e.g. `-rw-r--r--+1` instead of `-rw-r--r--+ 1`).
@sylvestre
ls: check ACL using full path, not bare filename (uutils#11789)
60fa35e 
When measuring column widths for the long listing, `has_acl` was
called with `item.display_name()` (the bare filename) instead of
`item.path()`. Listing a directory from a different cwd meant the
ACL lookups ran against the wrong directory, failed, and the `+`
marker column was never reserved — producing output like
`-rw-r--r--+1` with no separator before the link count.
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 20, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 309 untouched benchmarks
⏩ 46 skipped benchmarks1

Comparing sylvestre:issue-11789 (60fa35e) with main (0366d3c)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ls: no separator between permissions and link count

1 participant

@sylvestre