Skip to content

uucore: disable signals at simple utils for binary size and fast startup#11186

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:nosignal
Mar 4, 2026
Merged

uucore: disable signals at simple utils for binary size and fast startup#11186
sylvestre merged 1 commit intouutils:mainfrom
oech3:nosignal

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Mar 3, 2026

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will improve performance by ×4.4

⚡ 4 improved benchmarks
✅ 298 untouched benchmarks
⏩ 42 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation true_no_args 2,158.3 ns 842.5 ns ×2.6
Simulation true_consecutive_calls 28.3 µs 6.4 µs ×4.4
Simulation false_no_args 2,160.8 ns 844.2 ns ×2.6
Simulation false_consecutive_calls 28.6 µs 6.6 µs ×4.3

Comparing oech3:nosignal (30594e8) with main (e85d07d)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3
Copy link
Contributor Author

oech3 commented Mar 3, 2026

@naoNao89 @ChrisDryden #11186 (comment)

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/unexpand/bounded-memory is now being skipped but was previously passing.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)

@oech3 oech3 changed the title uucore: Allow disabling signals for simple utils e.g. true/false uucore: disable signals at simple utils for binary size and fast startup Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review March 3, 2026 14:20
@oech3
Copy link
Contributor Author

oech3 commented Mar 3, 2026

Can we remove signal handlers from echo, cat and mktemp except for SIGPIPE?

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@sylvestre
Copy link
Contributor

#11186 (comment)

what means this message ?
it is pointing to codspeed

@oech3
Copy link
Contributor Author

oech3 commented Mar 3, 2026

It was hyperfine result. But replaced later since CodSpeed is reliable more than it.

@sylvestre sylvestre merged commit e6cd47e into uutils:main Mar 4, 2026
163 checks passed
@oech3 oech3 deleted the nosignal branch March 5, 2026 00:31
@oech3
Copy link
Contributor Author

oech3 commented Mar 5, 2026

This improved perf 4.4x, that's fine. But this made true bench flakey...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants