Skip to content

nproc: Reject quota with some schedulers#11173

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:nproc-s
Open

nproc: Reject quota with some schedulers#11173
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:nproc-s

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Mar 2, 2026

Closes #9893 .
Difficult to add test. Also needs another fix to pass GNU tests.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/rm/isatty is no longer failing!
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3
Copy link
Contributor Author

oech3 commented Mar 2, 2026

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

libc function was detected.

@oech3 oech3 marked this pull request as ready for review March 2, 2026 06:00
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

GNU testsuite comparison:

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3

This comment was marked as resolved.

@oech3
Copy link
Contributor Author

oech3 commented Mar 4, 2026

coreutils/coreutils#212

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

GNU testsuite comparison:

Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2026

Merging this PR will degrade performance by 14.62%

⚡ 4 improved benchmarks
❌ 8 regressed benchmarks
✅ 292 untouched benchmarks
⏩ 42 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation unexpand_large_file[10] 281.5 ms 302.2 ms -6.86%
Simulation unexpand_many_lines[100000] 134.4 ms 144.3 ms -6.86%
Simulation sort_numeric[500000] 1 s 1 s +3.28%
Simulation seq_with_step 13.5 ms 12.7 ms +6.82%
Simulation seq_integers 26.6 ms 24.9 ms +6.81%
Simulation seq_custom_separator 29.3 ms 27.6 ms +6.15%
Simulation true_consecutive_calls 170.3 ns 199.4 ns -14.62%
Simulation false_consecutive_calls 170.3 ns 199.4 ns -14.62%
Simulation fold_custom_width[50000] 24.3 ms 25.3 ms -4.03%
Simulation fold_many_lines[100000] 61.8 ms 63.8 ms -3.18%
Simulation expand_custom_tabstops[50000] 16.6 ms 17.7 ms -6.38%
Simulation expand_many_lines[100000] 64.6 ms 68.4 ms -5.44%

Comparing oech3:nproc-s (ae0b647) with main (9654e4a)

Open in CodSpeed

Footnotes

  1. 42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 requested a review from sylvestre March 4, 2026 14:56
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/dd/no-allocate is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.
Note: The gnu test tests/nproc/nproc-quota was skipped on 'main' but is now failing.

@oech3
Copy link
Contributor Author

oech3 commented Mar 6, 2026

What happened for CodSpeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nproc: nproc-quota.sh?: Rejects schedular

2 participants