shuf: handle default RNG init failures gracefully#11162
shuf: handle default RNG init failures gracefully#11162jorgitin02 wants to merge 2 commits intouutils:mainfrom
Conversation
Signed-off-by: jorge guerrero <grrr.jrg@gmail.com>
|
Would you fallback instead of err? GNU's test suite decided to accept it. |
|
GNU testsuite comparison: |
Merging this PR will degrade performance by 3.38%
Performance Changes
Comparing Footnotes
|
This pr only touches shuf, so the cp_large_file[16] slowdown looks |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
This comment was marked as resolved.
This comment was marked as resolved.
|
GNU testsuite comparison: |
|
Please drop unrelated |
19f419e to
4e0ee46
Compare
done |
|
GNU testsuite comparison: |
|
Flakeyness of |
|
Closing this version and preparing a fresh follow-up. |
Fixes #11152.
This avoids panicking when default RNG initialization fails (for example when getrandom returns EAGAIN under syscall fault injection).
Changes: