bench: let shuf_input_range deterministic, drop broken b3sum#11160
Closed
oech3 wants to merge 1 commit intouutils:mainfrom
Closed
bench: let shuf_input_range deterministic, drop broken b3sum#11160oech3 wants to merge 1 commit intouutils:mainfrom
oech3 wants to merge 1 commit intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Merging this PR will improve performance by ×470
Performance Changes
Comparing 
Footnotes
|
xtqqczze
reviewed
Feb 28, 2026
| black_box(run_util_function(uumain, &["-i", &range_arg])); | ||
| black_box(run_util_function( | ||
| uumain, | ||
| &["-i", "--random-seed=1", &range_arg], |
Contributor
There was a problem hiding this comment.
nit: we could use empty string for the seed
Contributor
Author
There was a problem hiding this comment.
This bench is broken. We cannot use --random-seed. Also I don't see any reason to use empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11105