Skip to content

uucore: remove unused getpid and getsid functions#11158

Draft
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:rm-getpid
Draft

uucore: remove unused getpid and getsid functions#11158
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:rm-getpid

Conversation

@xtqqczze
Copy link
Contributor

No description provided.

@sylvestre
Copy link
Contributor

are you sure it isn't used by other consumers of uucore ?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 28, 2026

are you sure it isn't used by other consumers of uucore ?

nushell depends on uucore crate but not these functions, but other coreutils repos do:

https://github.com/uutils/procps/blob/4ebf73c7129c4ef637f2551690e8d72b861ff4f0/src/uu/pgrep/src/process.rs#L494

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Congrats! The gnu test tests/timeout/timeout-group is no longer failing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

@xtqqczze xtqqczze marked this pull request as draft February 28, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants