uucore: replace unsafe libc calls with safe nix crate wrappers#11156
Merged
sylvestre merged 1 commit intouutils:mainfrom Feb 28, 2026
Merged
uucore: replace unsafe libc calls with safe nix crate wrappers#11156sylvestre merged 1 commit intouutils:mainfrom
sylvestre merged 1 commit intouutils:mainfrom
Conversation
Replace direct unsafe libc function calls with safe nix crate wrappers for process management functions. This improves code safety and maintainability by leveraging nix's type-safe abstractions for system calls like geteuid, getpgrp, getsid, and signal handling. The changes maintain identical functionality while eliminating unsafe code blocks and providing better error handling.
|
GNU testsuite comparison: |
Contributor
|
@mattsu2020 Are you inrerested in replacing |
Contributor
Author
I thought nix was the standard, but it seems rustix is also in use. |
Contributor
|
I think rustix is wrapping |
Contributor
|
having less unsafe is ideal :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct unsafe libc function calls with safe nix crate wrappers for process management functions.
This improves code safety and maintainability by leveraging nix's type-safe abstractions for system calls like geteuid, getpgrp, getsid, and signal handling.
The changes maintain identical functionality while eliminating unsafe code blocks and providing better error handling.