cp: better permissions mode handling with umask awareness

[my4ng]

Fix #10787, #10862, Supersede #10859.

This PR reworks the permissions mode handling such that its behaviour is in line with GNU's implementation. Specifically:

• set umask to !0o077, which means (1) cp can actually create and work with new directories/files which will have 700 permissions mode before their final calculated mode is set. the original umask is kept and passed around for calculation in the case of newly created and non-mode-preserving dir/files. umask is restored to original on exit.

• for explicit non-mode-preserving, newly created dir/files, use 777 and 666 modes for calculation respectively.

• for newly created dir/files, always set their permission mode to the correct one.

• added 12 new tests for the combination of existing/not-existing, no-preserve/default/preserve, dir/file.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cp/cp-parents. tests/cp/cp-parents is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/factor/t34 is no longer failing!
Congrats! The gnu test tests/printf/printf-surprise is now passing!

[ChrisDryden]

Is there any way to split this PR up into something smaller? When its this big it gets pretty hard to review

[my4ng]

I'm afraid not. Most changes are actually from the noise of propagating orig_umask, and the only significant changes being build_dir and handle_mode. Without either, it results in a dozen or more failed tests.

There is a GNU test regression: tests/cp/cp-parents, caused by the second to last test in that file due to created parent dir not having attributes set correctly. Will fix soon.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/factor/t34 is no longer failing!
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.
Congrats! The gnu test tests/printf/printf-surprise is now passing!

[ChrisDryden]

I'm going to take a closer look at the overall logic later, but do you think it would be possible to use some of the built in integ test utilities for doing chmod and for creating files to condese the amount of code here. Do you think it also would be possible to parametrize the tests a bit more too to make it smaller and easier to read?

[my4ng]

What do you mean by integ test utilities? I think it should be possible to condense the twelve into one with some for loops, but I am not sure how readable or easily usable it becomes when it fails, but I will try it out.

[my4ng]

Also another problem is that there would have to be cleanup in between the various test cases if condensed, which makes it even more complex. I think keep them as separate tests is the best way to go.

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/cut/bounded-memory. tests/cut/bounded-memory is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/misc/io-errors. tests/misc/io-errors is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/factor/t10 is no longer failing!

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

[codspeed-hq]

Merging this PR will improve performance by 52.58%

⚡ 5 improved benchmarks
✅ 283 untouched benchmarks
⏩ 40 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Simulation	cp_preserve_metadata[(5, 4, 10)]	74.2 ms	59.3 ms	+25.22%
⚡	Simulation	cp_recursive_deep_tree[(120, 4)]	13.5 ms	8.9 ms	+52.58%
⚡	Simulation	cp_recursive_balanced_tree[(5, 4, 10)]	71.9 ms	56.6 ms	+26.98%
⚡	Simulation	cp_recursive_wide_tree[(6000, 800)]	188.5 ms	156.2 ms	+20.72%
⚡	Simulation	cp_archive_balanced_tree[(5, 4, 10)]	77.4 ms	62.2 ms	+24.33%

---

_{Comparing my4ng:cp_mode (f23a467) with main (a972eee)}

Footnotes

1. 40 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[my4ng]

There are some residual problems with copy_file that I want to fix. In particular, currently it is setting the permissions (unnecessarily) twice, but the change appears to be more complex than I anticipated. Might split that into a separate PR just for clarity since this one is working and big enough already.