Skip to content

expand: Fix perf regression with codegen-units=2#10874

Closed
oech3 wants to merge 3 commits intouutils:mainfrom
oech3:expand-cgu2-buf
Closed

expand: Fix perf regression with codegen-units=2#10874
oech3 wants to merge 3 commits intouutils:mainfrom
oech3:expand-cgu2-buf

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 11, 2026

Should be better than #10863

@oech3 oech3 changed the title Expand cgu2 buf expand: Avoid some perf regression with codegen-units=2~1 Feb 11, 2026
@oech3

This comment was marked as off-topic.

@oech3 oech3 force-pushed the expand-cgu2-buf branch 3 times, most recently from c2a8411 to e9aa027 Compare February 11, 2026 17:28
@oech3 oech3 changed the title expand: Avoid some perf regression with codegen-units=2~1 expand: Fix perf regression with codegen-units=2 Feb 11, 2026
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/pr/bounded-memory. tests/pr/bounded-memory is passing on 'main'. Maybe you have to rebase?

@oech3 oech3 marked this pull request as ready for review February 11, 2026 18:37
@xtqqczze
Copy link
Contributor

what is binary size for codegen-units=1,2,16 for this PR?

@oech3
Copy link
Contributor Author

oech3 commented Feb 13, 2026

After rebase,
16: 1210872
3: 1210264
2: 1210968
1: 1208024

Even they are bigger than bins at linked PR, we should fix this for coreutils binary (because we can't apply different cgu for expand of coreutils).

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/factor/t33 is no longer failing!
Congrats! The gnu test tests/factor/t35 is no longer failing!

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2026

Merging this PR will degrade performance by 38.22%

❌ 2 regressed benchmarks
⏩ 324 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation expand_many_lines[100000] 95.9 ms 155.2 ms -38.22%
Simulation expand_custom_tabstops[50000] 23.6 ms 37.4 ms -36.97%

Comparing oech3:expand-cgu2-buf (f79776f) with main (1e95554)

Open in CodSpeed

Footnotes

  1. 324 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@oech3 oech3 closed this Feb 17, 2026
@oech3 oech3 deleted the expand-cgu2-buf branch February 17, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants