Skip to content

Properly cancel the rpc futures as to stop the client&server in the json-rpc tests#2768

Merged
DavyLandman merged 2 commits intomainfrom
fix/errors-in-json-rpc-test-teardown
Apr 23, 2026
Merged

Properly cancel the rpc futures as to stop the client&server in the json-rpc tests#2768
DavyLandman merged 2 commits intomainfrom
fix/errors-in-json-rpc-test-teardown

Conversation

@DavyLandman
Copy link
Copy Markdown
Member

@DavyLandman DavyLandman commented Apr 22, 2026

This fixes the

Task java.util.concurrent.FutureTask@55362a0e[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@140b2035[Wrapped task = org.eclipse.lsp4j.jsonrpc.json.ConcurrentMessageProcessor@1034a66c]] rejected from java.util.concurrent.ThreadPoolExecutor@296ea999[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1]

prints that every test had.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46%. Comparing base (f6d6bbe) to head (a7bad44).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2768   +/-   ##
=======================================
- Coverage       46%     46%   -1%     
- Complexity    6725    6727    +2     
=======================================
  Files          794     794           
  Lines        65923   65923           
  Branches      9888    9888           
=======================================
- Hits         30837   30835    -2     
- Misses       32696   32700    +4     
+ Partials      2390    2388    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/org/rascalmpl/test/rpc/IValueOverJsonTests.java
Comment thread test/org/rascalmpl/test/rpc/IValueOverJsonTests.java Outdated
Comment thread test/org/rascalmpl/test/rpc/IValueOverJsonTests.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

@DavyLandman DavyLandman merged commit f497747 into main Apr 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants