test: regression for #2234 empty positional arg after a flag#2328
Open
c-tonneslan wants to merge 1 commit into
Open
test: regression for #2234 empty positional arg after a flag#2328c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it
Issue #2234 reported that an empty positional arg following a flag (e.g.
app -f=val "" arg2 arg3) got dropped along with every arg after it. The bug isn't reproducible on currentmain(the existingTestEmptyPositionalArgscases all pass), but there's no test that pins down the case where a flag and an empty positional are mixed, which is exactly what the issue described.Adding a small regression test so the case doesn't quietly break again. Covers both
-f=valand-f valforms.Which issue(s) this PR fixes
Fixes #2234
Testing
go test -run TestEmptyPositionalArgs -vpasses both the existing cases and the two new ones.Release Notes