feat: support dynamic fish completion#2270
Merged
dearchap merged 1 commit intourfave:mainfrom Mar 1, 2026
Merged
Conversation
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
Mar 1, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | minor | `v3.6.2` → `v3.7.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/urfave/cli) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.7.0`](https://github.com/urfave/cli/releases/tag/v3.7.0) [Compare Source](urfave/cli@v3.6.2...v3.7.0) #### What's Changed - Fix: use the correct type name in the tracef message by [@​icholy](https://github.com/icholy) in [#​2251](urfave/cli#2251) - chore(deps): bump mkdocs-git-revision-date-localized-plugin from 1.5.0 to 1.5.1 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2252](urfave/cli#2252) - Fix:(issue\_2254) Fix incorrect handling of arg after short option token by [@​dearchap](https://github.com/dearchap) in [#​2255](urfave/cli#2255) - feat: ShellComplete for fish by [@​marcusramberg](https://github.com/marcusramberg) in [#​2256](urfave/cli#2256) - Fix: propagate MutuallyExclusiveFlags persistent flags to subcommands by [@​siutsin](https://github.com/siutsin) in [#​2266](urfave/cli#2266) - feat: support dynamic fish completion by [@​Maks1mS](https://github.com/Maks1mS) in [#​2270](urfave/cli#2270) - fix(help): show GLOBAL OPTIONS for leaf subcommands when HideHelpCommand is true by [@​TimSoethout](https://github.com/TimSoethout) in [#​2269](urfave/cli#2269) #### New Contributors - [@​marcusramberg](https://github.com/marcusramberg) made their first contribution in [#​2256](urfave/cli#2256) - [@​siutsin](https://github.com/siutsin) made their first contribution in [#​2266](urfave/cli#2266) - [@​TimSoethout](https://github.com/TimSoethout) made their first contribution in [#​2269](urfave/cli#2269) **Full Changelog**: <urfave/cli@v3.6.2...v3.7.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNS4yIiwidXBkYXRlZEluVmVyIjoiNDMuMTUuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/340 Co-authored-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space> Co-committed-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
The previous fish shell completion implementation generated completions statically at install time by embedding all subcommands and flags directly into the completion script. The primary motivation for this change is multilingual support: static completions make it impossible to provide localized descriptions, since the language cannot be determined until runtime.
I understand this is a significant change and may introduce compatibility concerns. I'm open to discussing the best approach - for example, adding a boolean field to opt into the new dynamic completion behavior, or any other alternative you think fits better.
Which issue(s) this PR fixes:
(REQUIRED)
Replaces #2144
Special notes for your reviewer:
(fill-in or delete this section)
I suspect that all existing zsh problems will become relevant for fish when merging this PR, which means it will be a possible regression.
Maybe it's worth making the new behavior optional to gather feedback or something like that?
Testing
(fill-in or delete this section)
I added unit tests similar to zsh, but it seems this requires manual testing. In my scenarios it works well (on par with zsh).
Release Notes
(REQUIRED)