Skip to content

fix: log failure reason before COMPLETE and fix misleading SCRAPE ✓ (#1949) #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntohidi merged 1 commit into from
May 5, 2026
+10 −2
Merged

fix: log failure reason before COMPLETE and fix misleading SCRAPE ✓ (#1949) #1952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions crawl4ai/async_webcrawler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,14 @@ async def arun(
head_html = crawl_result.html[:head_end + 7]
crawl_result.head_fingerprint = compute_head_fingerprint(head_html)

# Log failure reason before COMPLETE so users can see why it failed.
if crawl_result and not crawl_result.success and crawl_result.error_message:
self.logger.error_status(
url=cache_context.display_url,
error=crawl_result.error_message,
tag="ERROR",
)

self.logger.url_status(
url=cache_context.display_url,
success=crawl_result.success if crawl_result else False,
Expand Down Expand Up @@ -852,10 +860,10 @@ async def aprocess_html(
)
)

# Log processing completion
# Log processing completion — reflect actual content outcome
self.logger.url_status(
url=_url,
success=True,
success=bool(cleaned_html),
timing=int((time.perf_counter() - t1) * 1000) / 1000,
tag="SCRAPE"
)
Expand Down