remove variable reference that does not exist#4125
remove variable reference that does not exist#4125athoynilimanew wants to merge 3 commits intoukaea:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4125 +/- ##
=======================================
Coverage 47.51% 47.51%
=======================================
Files 141 141
Lines 29487 29490 +3
=======================================
+ Hits 14010 14013 +3
Misses 15477 15477 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kj5248
left a comment
There was a problem hiding this comment.
I think actually the issue might be incorrect and that the changed block is supposed to be there but it is instead missing from the data_structure file. Having looked at some of the other cases (commented on them) I think this parameter just needs to be added to the current_drive_variables.py file in the required places. Worth checking with @chris-ashe as he wrote the current drive models.
Suggestion in current_drive_variables.py:
Add somewhere near line 107:
p_hcd_icrh_electric_mw : float = None
"""Ion cyclotron wall plug power (MW)"""
Add somewhere near line 407:
p_hcd_icrh_electric_mw, \
Add somewhere near line 537:
p_hcd_icrh_electric_mw = 0.0
| # Wall plug power | ||
| current_drive_variables.p_hcd_ecrh_electric_mw = ( | ||
| current_drive_variables.p_hcd_ecrh_injected_total_mw | ||
| / current_drive_variables.eta_ecrh_injector_wall_plug | ||
| ) |
| # Wall plug power | ||
| current_drive_variables.p_hcd_ebw_electric_mw = ( | ||
| current_drive_variables.p_ebw_injected_mw | ||
| / current_drive_variables.eta_ebw_injector_wall_plug | ||
| ) |
Done! |
Description
closes #4012
Checklist
I confirm that I have completed the following checks: