Skip to content

remove variable reference that does not exist#4125

Open
athoynilimanew wants to merge 3 commits intoukaea:mainfrom
athoynilimanew:anilima/papercut_obsolete_variable_references_#4012
Open

remove variable reference that does not exist#4125
athoynilimanew wants to merge 3 commits intoukaea:mainfrom
athoynilimanew:anilima/papercut_obsolete_variable_references_#4012

Conversation

@athoynilimanew
Copy link
Collaborator

@athoynilimanew athoynilimanew commented Mar 9, 2026

Description

closes #4012

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@athoynilimanew athoynilimanew requested a review from a team as a code owner March 9, 2026 09:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.51%. Comparing base (67340b1) to head (4924f02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4125   +/-   ##
=======================================
  Coverage   47.51%   47.51%           
=======================================
  Files         141      141           
  Lines       29487    29490    +3     
=======================================
+ Hits        14010    14013    +3     
  Misses      15477    15477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@kj5248 kj5248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think actually the issue might be incorrect and that the changed block is supposed to be there but it is instead missing from the data_structure file. Having looked at some of the other cases (commented on them) I think this parameter just needs to be added to the current_drive_variables.py file in the required places. Worth checking with @chris-ashe as he wrote the current drive models.

Suggestion in current_drive_variables.py:

Add somewhere near line 107:

p_hcd_icrh_electric_mw : float = None
"""Ion cyclotron wall plug power (MW)"""

Add somewhere near line 407:

p_hcd_icrh_electric_mw, \

Add somewhere near line 537:

p_hcd_icrh_electric_mw = 0.0

Comment on lines 1943 to 1947
# Wall plug power
current_drive_variables.p_hcd_ecrh_electric_mw = (
current_drive_variables.p_hcd_ecrh_injected_total_mw
/ current_drive_variables.eta_ecrh_injector_wall_plug
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

Comment on lines 1974 to 1978
# Wall plug power
current_drive_variables.p_hcd_ebw_electric_mw = (
current_drive_variables.p_ebw_injected_mw
/ current_drive_variables.eta_ebw_injector_wall_plug
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different example

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@athoynilimanew
Copy link
Collaborator Author

I think actually the issue might be incorrect and that the changed block is supposed to be there but it is instead missing from the data_structure file. Having looked at some of the other cases (commented on them) I think this parameter just needs to be added to the current_drive_variables.py file in the required places. Worth checking with @chris-ashe as he wrote the current drive models.

Suggestion in current_drive_variables.py:

Add somewhere near line 107:

p_hcd_icrh_electric_mw : float = None
"""Ion cyclotron wall plug power (MW)"""

Add somewhere near line 407:

p_hcd_icrh_electric_mw, \

Add somewhere near line 537:

p_hcd_icrh_electric_mw = 0.0

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Variables referenced that don't exist

3 participants